]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: don't fail with newer gnutls
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 2 May 2014 07:55:52 +0000 (09:55 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Fri, 2 May 2014 07:56:33 +0000 (09:56 +0200)
gnutls-3.3.0 and newer leaves 2 FDs open in order to be backwards
compatible when it comes to chrooted binaries [1].  Linking
commandhelper with gnutls then leaves these two FDs open and
commandtest fails thanks to that.  This patch does not link
commandhelper with libvirt.la, but rather only the utilities making
the test pass.

Based on suggestion from Daniel [2].

[1] http://lists.gnutls.org/pipermail/gnutls-help/2014-April/003429.html
[2] https://www.redhat.com/archives/libvir-list/2014-April/msg01119.html

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
tests/Makefile.am

index 4a5e14bd78a90ffb1b7acd826589c64b4874193a..7ffb44e52a0b6e294a6bbd8b81908406857ef96e 100644 (file)
@@ -782,7 +782,13 @@ commandtest_LDADD = $(LDADDS)
 
 commandhelper_SOURCES = \
        commandhelper.c
-commandhelper_LDADD = $(LDADDS)
+commandhelper_LDADD = \
+       $(WARN_CFLAGS) \
+       $(NO_INDIRECT_LDFLAGS) \
+       $(PROBES_O) \
+       ../src/libvirt_util.la \
+       $(GNULIB_LIBS)
+
 commandhelper_LDFLAGS = -static
 
 virnetdevbandwidthtest_SOURCES = \