]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Copy bitmap in a sane way
authorPeter Krempa <pkrempa@redhat.com>
Fri, 27 Mar 2015 12:56:30 +0000 (13:56 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 2 Apr 2015 08:12:09 +0000 (10:12 +0200)
Use virBitmapNewCopy instead of a combination of virBitmapNew and
virBitmapCopy.

src/qemu/qemu_driver.c

index 3ce8d27be56f7156df1e2628eacfa67c2e5af47b..9ac056f7e8a08367d72a80e6d5a0220a884c77d5 100644 (file)
@@ -4759,12 +4759,10 @@ static int qemuDomainHotplugVcpus(virQEMUDriverPtr driver,
                 if (VIR_ALLOC(vcpupin) < 0)
                     goto cleanup;
 
-                if (!(vcpupin->cpumask =
-                      virBitmapNew(VIR_DOMAIN_CPUMASK_LEN))) {
+                if (!(vcpupin->cpumask = virBitmapNewCopy(vm->def->cpumask))) {
                     VIR_FREE(vcpupin);
                     goto cleanup;
                 }
-                virBitmapCopy(vcpupin->cpumask, vm->def->cpumask);
                 vcpupin->id = i;
                 if (VIR_APPEND_ELEMENT_COPY(vm->def->cputune.vcpupin,
                                             vm->def->cputune.nvcpupin, vcpupin) < 0) {