]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
iommu/amd-vi: fix assert comparing boolean to enum
authorRoger Pau Monné <roger.pau@citrix.com>
Fri, 12 May 2023 07:35:36 +0000 (09:35 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 12 May 2023 07:35:36 +0000 (09:35 +0200)
Or else when iommu_intremap is set to iommu_intremap_full the assert
triggers.

Fixes: 1ba66a870eba ('AMD/IOMMU: without XT, x2APIC needs to be forced into physical mode')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/passthrough/amd/pci_amd_iommu.c

index 4ba8e764b22f4b5bfd6772071144cfecfa323816..94e37755064b62bfe5c38d0b758d9d82e9de3e6e 100644 (file)
@@ -240,7 +240,7 @@ static int __must_check amd_iommu_setup_domain_device(
          */
         if ( dte->it_root )
             ASSERT(dte->int_ctl == IOMMU_DEV_TABLE_INT_CONTROL_TRANSLATED);
-        ASSERT(dte->iv == iommu_intremap);
+        ASSERT(dte->iv == !!iommu_intremap);
         ASSERT(dte->ex == ivrs_dev->dte_allow_exclusion);
         ASSERT(dte->sys_mgt == MASK_EXTR(ivrs_dev->device_flags,
                                          ACPI_IVHD_SYSTEM_MGMT));