]> xenbits.xensource.com Git - xen.git/commitdiff
x86/EPT: squash meaningless TLB flush
authorJan Beulich <jbeulich@suse.com>
Tue, 4 Jan 2022 09:13:06 +0000 (10:13 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 4 Jan 2022 09:13:06 +0000 (10:13 +0100)
ept_free_entry() gets called after a flush was already issued, if one is
necessary in the first place. That behavior is similar to NPT, which
also doesn't have any further flush in p2m_free_entry(). (Furthermore,
the function being recursive, in case of recursiveness way too many
flushes would have been issued.)

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
xen/arch/x86/mm/p2m-ept.c

index a4f5fc4b0df086ca8cb93eebc0ddcb9d2290e741..b7ee441d457371581144d2d172b7a4e0ea7a52fc 100644 (file)
@@ -246,8 +246,7 @@ static void ept_free_entry(struct p2m_domain *p2m, ept_entry_t *ept_entry, int l
             ept_free_entry(p2m, epte + i, level - 1);
         unmap_domain_page(epte);
     }
-    
-    p2m_tlb_flush_sync(p2m);
+
     p2m_free_ptp(p2m, mfn_to_page(_mfn(ept_entry->mfn)));
 }