qemuMigrationSrcBegin: Automatically free 'xml' variable on error

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 25af291dc6c8a3ba3719e1f9afbf46f356b7aca9..6b3815ac589e79768ec97a315a3db70f86bf1b13 100644 (file)
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2487,7 +2487,7 @@ qemuMigrationSrcBegin(virConnectPtr conn,
 {
     virQEMUDriver *driver = conn->privateData;
     g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
-    char *xml = NULL;
+    g_autofree char *xml = NULL;
     virDomainAsyncJob asyncJob;
 
     if (cfg->migrateTLSForce &&
@@ -2532,10 +2532,8 @@ qemuMigrationSrcBegin(virConnectPtr conn,
          * place.
          */
         if (virCloseCallbacksSet(driver->closeCallbacks, vm, conn,
-                                 qemuMigrationSrcCleanup) < 0) {
-            VIR_FREE(xml);
+                                 qemuMigrationSrcCleanup) < 0)
             goto endjob;
-        }
         qemuMigrationJobContinue(vm);
     } else {
         goto endjob;
@@ -2543,7 +2541,7 @@ qemuMigrationSrcBegin(virConnectPtr conn,
 
  cleanup:
     virDomainObjEndAPI(&vm);
-    return xml;
+    return g_steal_pointer(&xml);
 
  endjob:
     if (flags & VIR_MIGRATE_CHANGE_PROTECTION)