netrom: Fix a data-race around sysctl_netrom_transport_no_activity_timeout

[ Upstream commit f99b494b40431f0ca416859f2345746199398e2b ]

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 88941b66631fca60794bccc51d1897545165edca..5472e79cde8309c5cfd3567c8c43c3276c12b3cf 100644 (file)
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -461,7 +461,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol,
        nr->t4     =
                msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_busy_delay));
        nr->idle   =
-               msecs_to_jiffies(sysctl_netrom_transport_no_activity_timeout);
+               msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_no_activity_timeout));
        nr->window = READ_ONCE(sysctl_netrom_transport_requested_window_size);
 
        nr->bpqext = 1;