]> xenbits.xensource.com Git - people/aperard/linux-chromebook.git/commitdiff
BACKPORT: hid: Fix uninitialized variable "size" in hid-wiimote-debug
authorSimon Que <sque@chromium.org>
Thu, 17 Jan 2013 19:44:47 +0000 (11:44 -0800)
committerChromeBot <chrome-bot@google.com>
Thu, 17 Jan 2013 22:18:46 +0000 (14:18 -0800)
This variable is initialized conditionally, based on whether a wiimote
call succeeds.  However, the logic is not obvious to the compiler so it
throws a warning.  Eliminate the warning by initializing "size" to 0.

The warning is:
files/drivers/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
uninitialized in this function [-Wmaybe-uninitialized]

BUG=chromium-os:5542
TEST=emerge-daisy chromeos-kernel, make sure this warning doesn't appear

Change-Id: I63896a2dd9e08cfd25b25b81d447c7fe9baeae2f
Signed-off-by: Simon Que <sque@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/41558
Reviewed-by: Mandeep Singh Baines <msb@chromium.org>
drivers/hid/hid-wiimote-debug.c

index eec329197c160e6739ccf1cbb0a24adc766b15ee..90124ffaa2a5211f3e7e11ec7c4a21aedd18b054 100644 (file)
@@ -31,7 +31,7 @@ static ssize_t wiidebug_eeprom_read(struct file *f, char __user *u, size_t s,
        unsigned long flags;
        ssize_t ret;
        char buf[16];
-       __u16 size;
+       __u16 size = 0;
 
        if (s == 0)
                return -EINVAL;