]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Call virResetLastError in all virConnectOpen* functions
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 10 Sep 2012 15:47:15 +0000 (16:47 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 11 Sep 2012 11:16:17 +0000 (12:16 +0100)
All public API functions must call virResetLastError to clear
out any previous error. The virConnectOpen* functions forgot
to do this.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/libvirt.c

index 686af8a744000307b289594e6f529dd3b7f81fc5..563985062fd5f12d253597f01fd9ea83de6c2f43 100644 (file)
@@ -1329,6 +1329,7 @@ virConnectOpen (const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, 0);
     if (!ret)
         goto error;
@@ -1363,6 +1364,7 @@ virConnectOpenReadOnly(const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, VIR_CONNECT_RO);
     if (!ret)
         goto error;
@@ -1401,6 +1403,7 @@ virConnectOpenAuth(const char *name,
             goto error;
 
     VIR_DEBUG("name=%s, auth=%p, flags=%x", NULLSTR(name), auth, flags);
+    virResetLastError();
     ret = do_open (name, auth, flags);
     if (!ret)
         goto error;