Fix missing check for memory allocation failure

diff --git a/ChangeLog b/ChangeLog
index 8a9359b171dc1ee983c10c09dfcdae0362e7a49c..14cd4bc93ec292dc8bb65939f4e77e9a4d34e37c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+Thu May 29 14:44:00 EST 2008 Daniel P. Berrange <berrange@redhat.com>
+
+       * src/xend_internal.c: Fix missing check for failure
+
 Thu May 29 11:29:00 EST 2008 Daniel P. Berrange <berrange@redhat.com>
 
        * tests/nodeinfotest.c, tests/qemuxml2argvtest.c,

diff --git a/src/xend_internal.c b/src/xend_internal.c
index df204251d3b9a9927001179d1862aae3d705160f..d90a19bbbf2e04eb8527a6594b4c25803057b2da 100644 (file)
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -924,6 +924,10 @@ char *sound_string_to_xml(const char *sound) {
             // and build with all available models
             if (STREQ(model, "all")) {
                 int i;
+                if (virBufferError(&buf)) {
+                    free(model);
+                    goto error;
+                }
                 free(virBufferContentAndReset(&buf));
 
                 for (i=0; i < sizeof(sound_models)/sizeof(*sound_models); ++i)