]> xenbits.xensource.com Git - pvdrivers/win/xeniface.git/commitdiff
Don't call DbgPrint (or variants) from an event channel callback
authorPaul Durrant <paul.durrant@citrix.com>
Fri, 11 Nov 2016 14:58:25 +0000 (14:58 +0000)
committerPaul Durrant <paul.durrant@citrix.com>
Fri, 11 Nov 2016 14:58:25 +0000 (14:58 +0000)
Windows debug primitives will IPI so it's not a good idea to use them
from within an interrupt handler which may get called at HIGH_LEVEL.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
src/xeniface/ioctl_evtchn.c

index 5fb8bec10b0a66cc7eb40d03d6f80b189d93cc96..b9b0e27d4ea18f8d964028ac52a3afc6650db818 100644 (file)
@@ -84,10 +84,7 @@ EvtchnInterruptHandler(
     KeGetCurrentProcessorNumberEx(&ProcNumber);
     ProcIndex = KeGetProcessorIndexFromNumber(&ProcNumber);
 
-    if (!KeInsertQueueDpc(&Context->Dpc, NULL, NULL)) {
-        XenIfaceDebugPrint(TRACE, "NOT INSERTED: Context %p, Port %lu, FO %p, Cpu %lu\n",
-                           Context, Context->LocalPort, Context->FileObject, ProcIndex);
-    }
+    (VOID) KeInsertQueueDpc(&Context->Dpc, NULL, NULL);
 
     return TRUE;
 }