]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
contrib/plugins/execlog: Fix shadowed declaration warning
authorPierrick Bouvier <pierrick.bouvier@linaro.org>
Wed, 14 Aug 2024 23:36:40 +0000 (16:36 -0700)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 19 Aug 2024 22:49:14 +0000 (00:49 +0200)
Found on debian stable.

../contrib/plugins/execlog.c: In function ‘vcpu_tb_trans’:
../contrib/plugins/execlog.c:236:22: error: declaration of ‘n’ shadows a previous local [-Werror=shadow=local]
  236 |             for (int n = 0; n < all_reg_names->len; n++) {
      |                      ^
../contrib/plugins/execlog.c:184:12: note: shadowed declaration is here
  184 |     size_t n = qemu_plugin_tb_n_insns(tb);
      |

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240814233645.944327-2-pierrick.bouvier@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
contrib/plugins/execlog.c

index 1c1601cc0b4f99cea56cb1383d0a30e77e2bf345..d67d0107613fc80dd09bee96b0c07bed8bfee01a 100644 (file)
@@ -181,8 +181,8 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
     bool check_regs_this = rmatches;
     bool check_regs_next = false;
 
-    size_t n = qemu_plugin_tb_n_insns(tb);
-    for (size_t i = 0; i < n; i++) {
+    size_t n_insns = qemu_plugin_tb_n_insns(tb);
+    for (size_t i = 0; i < n_insns; i++) {
         char *insn_disas;
         uint64_t insn_vaddr;