]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuProcessUpdateAndVerifyCPU: Refactor cleanup
authorPeter Krempa <pkrempa@redhat.com>
Mon, 7 Feb 2022 09:57:11 +0000 (10:57 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 7 Feb 2022 17:04:52 +0000 (18:04 +0100)
Use automatic memory clearing and remove the 'ret' variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_process.c

index ea586e54c146d0e993e5cbd34f23789750204316..d080ab1c49f2374f4de78f8d33c4a6c24f32ad78 100644 (file)
@@ -4335,25 +4335,19 @@ qemuProcessUpdateAndVerifyCPU(virQEMUDriver *driver,
                               virDomainObj *vm,
                               qemuDomainAsyncJob asyncJob)
 {
-    virCPUData *cpu = NULL;
-    virCPUData *disabled = NULL;
-    int ret = -1;
+    g_autoptr(virCPUData) cpu = NULL;
+    g_autoptr(virCPUData) disabled = NULL;
 
     if (qemuProcessFetchGuestCPU(driver, vm, asyncJob, &cpu, &disabled) < 0)
-        goto cleanup;
+        return -1;
 
     if (qemuProcessVerifyCPU(vm, cpu) < 0)
-        goto cleanup;
+        return -1;
 
     if (qemuProcessUpdateLiveGuestCPU(vm, cpu, disabled) < 0)
-        goto cleanup;
-
-    ret = 0;
+        return -1;
 
- cleanup:
-    virCPUDataFree(cpu);
-    virCPUDataFree(disabled);
-    return ret;
+    return 0;
 }