]> xenbits.xensource.com Git - xen.git/commitdiff
libxl: check return value of libxl_vcpu_setaffinity
authorWei Liu <wei.liu2@citrix.com>
Wed, 8 Apr 2015 16:05:24 +0000 (17:05 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Wed, 15 Apr 2015 15:52:54 +0000 (16:52 +0100)
That function can fail.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl_dom.c

index 9711fb647d45d9c64184e353783c112daa608bb7..f408646ea0a832a42df6d97f6076a71d7a3010c1 100644 (file)
@@ -468,8 +468,13 @@ static int set_vnuma_affinity(libxl__gc *gc, uint32_t domid,
             goto out;
         }
 
-        libxl_for_each_set_bit(j, v->vcpus)
-            libxl_set_vcpuaffinity(CTX, domid, j, NULL, &cpumap);
+        libxl_for_each_set_bit(j, v->vcpus) {
+            rc = libxl_set_vcpuaffinity(CTX, domid, j, NULL, &cpumap);
+            if (rc) {
+                LOG(ERROR, "Can't set cpu affinity for %d", j);
+                goto out;
+            }
+        }
     }
 
 out: