]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainBackupDiskDefParseXML: Fill default backup state after parsing it
authorPeter Krempa <pkrempa@redhat.com>
Thu, 6 May 2021 14:01:32 +0000 (16:01 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 7 May 2021 08:06:18 +0000 (10:06 +0200)
Set the backup mode to VIR_TRISTATE_BOOL_YES after virXMLPropTristateBool
left it set to VIR_TRISTATE_BOOL_ABSENT. This will allow fixing
virXMLPropTristateBool to always initialize @result.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/backup_conf.c

index 7f176b783f84958059da2a0a2f25441e84f47050..ac92bd4f26a47ee4454e307c52946d80bb544e87 100644 (file)
@@ -121,12 +121,13 @@ virDomainBackupDiskDefParseXML(xmlNodePtr node,
         return -1;
     }
 
-    def->backup = VIR_TRISTATE_BOOL_YES;
-
     if (virXMLPropTristateBool(node, "backup", VIR_XML_PROP_NONE,
                                &def->backup) < 0)
         return -1;
 
+    if (def->backup == VIR_TRISTATE_BOOL_ABSENT)
+        def->backup = VIR_TRISTATE_BOOL_YES;
+
     /* don't parse anything else if backup is disabled */
     if (def->backup == VIR_TRISTATE_BOOL_NO)
         return 0;