]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
hw/ppc/spapr: Reduce "vof.h" inclusion
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 13 Dec 2022 12:35:49 +0000 (13:35 +0100)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Wed, 21 Dec 2022 17:17:55 +0000 (14:17 -0300)
Currently objects including "hw/ppc/spapr.h" are forced to be
target specific due to the inclusion of "vof.h" in "spapr.h".

"spapr.h" only uses a Vof pointer, so doesn't require the structure
declaration. The only place where Vof structure is accessed is in
spapr.c, so include "vof.h" there, and forward declare the structure
in "spapr.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20221213123550.39302-4-philmd@linaro.org>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
hw/ppc/spapr.c
include/hw/ppc/spapr.h

index dc850032ae59a468042e70421764a5f4e7a0965a..59641adaec80bf4218c9da12c104efa852597eb9 100644 (file)
@@ -62,6 +62,7 @@
 #include "hw/ppc/fdt.h"
 #include "hw/ppc/spapr.h"
 #include "hw/ppc/spapr_vio.h"
+#include "hw/ppc/vof.h"
 #include "hw/qdev-properties.h"
 #include "hw/pci-host/spapr.h"
 #include "hw/pci/msi.h"
index 04a95669ab6ba1bef33d2345f6fa5c7f6e7bec37..5c8aabd4443d6c9deabd90b32ad8231809002ec0 100644 (file)
@@ -12,7 +12,6 @@
 #include "hw/ppc/spapr_xive.h"  /* For SpaprXive */
 #include "hw/ppc/xics.h"        /* For ICSState */
 #include "hw/ppc/spapr_tpm_proxy.h"
-#include "hw/ppc/vof.h"
 
 struct SpaprVioBus;
 struct SpaprPhbState;
@@ -22,6 +21,8 @@ typedef struct SpaprEventLogEntry SpaprEventLogEntry;
 typedef struct SpaprEventSource SpaprEventSource;
 typedef struct SpaprPendingHpt SpaprPendingHpt;
 
+typedef struct Vof Vof;
+
 #define HPTE64_V_HPTE_DIRTY     0x0000000000000040ULL
 #define SPAPR_ENTRY_POINT       0x100