]> xenbits.xensource.com Git - unikraft/libs/musl.git/commitdiff
Config.uk: Disable default LIBMUSL_COMPLEX
authorRazvan Deaconescu <razvand@unikraft.io>
Wed, 10 May 2023 16:00:33 +0000 (19:00 +0300)
committerUnikraft <monkey@unikraft.io>
Wed, 10 May 2023 17:54:19 +0000 (17:54 +0000)
When using Clang to build Musl with complex numbers support, a linking
error appears: `__muldc3` symbol is undefined. For Clang, the `__muldc3`
symbol is implemented by `libcompiler-rt`.

As complex number support is not typically required by applications
(that use Musl), this commit disable it by setting the `LIBMUSL_COMPLEX`
option to `n`. If required, the application will enable
`LIBMUSL_COMPLEX` (set it to `y`) and, in the case of Clang, add
`libcompiler-rt`.

Signed-off-by: Razvan Deaconescu <razvand@unikraft.io>
Reviewed-by: Stefan Jumarea <stefanjumarea02@gmail.com>
Reviewed-by: Andrei Tatar <andrei@unikraft.io>
Approved-by: Maria Sfiraiala <maria.sfiraiala@gmail.com>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #47

Config.uk

index 6dd37c5a11a13d7094997fb13037aa4ce24a1fe1..f199a6a85c74c27eb868b94f9e3440c4e67fb6c0 100644 (file)
--- a/Config.uk
+++ b/Config.uk
@@ -38,7 +38,7 @@ config LIBMUSL_AIO
 
 config LIBMUSL_COMPLEX
   bool "libcomplex"
-  default y
+  default n
 
 config LIBMUSL_CONF
   bool "libconf"