]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
meson.build: Detect bzip2 program
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Thu, 14 Jan 2021 17:45:09 +0000 (18:45 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 23 Jan 2021 20:55:07 +0000 (15:55 -0500)
The --enable-bzip2/--disable-bzip2 configure arguments are
somehow misleading, they check for the bzip2 library, not
the bzip2 program.

We need the bzip2 program to install the EDK2 firmware blobs
(see commit 623ef637a2e "configure: Check bzip2 is available").

Check if the bzip2 program in the global meson.build to avoid
the configuration to succeed, but a later when trying to install
the firmware blobs:

    ../pc-bios/meson.build:5:2: ERROR: Program 'bzip2' not found

Reported-by: John Snow <jsnow@redhat.com>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Fixes: c8d5450bba3 ("configure: move install_blobs from configure to meson")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210114174509.2944817-3-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
meson.build
pc-bios/meson.build

index 94bbb4c75782d7cc810f7434121fe10805eccfa7..35a9eddf5cf883a166b477d1809afa0fa703149c 100644 (file)
@@ -96,6 +96,8 @@ if get_option('install_blobs')
   endforeach
 endif
 
+bzip2 = find_program('bzip2', required: install_edk2_blobs)
+
 ##################
 # Compiler flags #
 ##################
index 6a341b6cea08b852860b4db1f962569278e19d1f..af95c5d1f1db2207459e349d397dc408c7e24126 100644 (file)
@@ -1,5 +1,4 @@
 if install_edk2_blobs
-  bzip2 = find_program('bzip2', required: true)
   fds = [
     'edk2-aarch64-code.fd',
     'edk2-arm-code.fd',