]> xenbits.xensource.com Git - qemu-xen-unstable.git/commitdiff
hw/dma/omap_dma: Move switch 'fall through' comment to correct place
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 19 Jul 2019 13:14:20 +0000 (15:14 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Wed, 21 Aug 2019 08:55:23 +0000 (10:55 +0200)
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:

    CC      hw/dma/omap_dma.o
  hw/dma/omap_dma.c: In function ‘omap_dma_write’:
  hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
   1532 |         if (s->model <= omap_dma_3_1)
        |            ^
  hw/dma/omap_dma.c:1534:5: note: here
   1534 |     case 0x400:
        |     ^~~~
  cc1: all warnings being treated as errors

Correctly place the 'fall through' comment.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20190719131425.10835-3-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/dma/omap_dma.c

index eab83c5c3a16fbb9de2b9e5141de5ee114e8f378..6677237d42a4f6334c84002aa45a77006e23cfae 100644 (file)
@@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr,
     case 0x404 ... 0x4fe:
         if (s->model <= omap_dma_3_1)
             break;
+        /* fall through */
     case 0x400:
-        /* Fall through. */
         if (omap_dma_sys_write(s, addr, value))
             break;
         return;