]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Move freeing of PCI address list to qemuProcessStop
authorPeter Krempa <pkrempa@redhat.com>
Wed, 26 Apr 2017 08:27:49 +0000 (10:27 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 28 Apr 2017 07:26:24 +0000 (09:26 +0200)
Rather than freeing the list before starting a new VM clear it after
stopping the old instance when the data becomes invalid.

src/qemu/qemu_domain_address.c
src/qemu/qemu_process.c

index 064d05079c66f02c4bc383e6107c0d462152597f..203a367acc9596dc4ce21f530d2791e86ad4ebf3 100644 (file)
@@ -2221,7 +2221,6 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def,
     if (obj && obj->privateData) {
         priv = obj->privateData;
         /* if this is the live domain object, we persist the PCI addresses */
-        virDomainPCIAddressSetFree(priv->pciaddrs);
         priv->pciaddrs = addrs;
         addrs = NULL;
     }
index 3197aa9fade5c3df49f16a68e42880da6bb0139e..ea3e45c024441146a212f177d972635b5172e46b 100644 (file)
@@ -6444,6 +6444,8 @@ void qemuProcessStop(virQEMUDriverPtr driver,
     priv->autoCpuset = NULL;
 
     /* remove address data */
+    virDomainPCIAddressSetFree(priv->pciaddrs);
+    priv->pciaddrs = NULL;
     virDomainUSBAddressSetFree(priv->usbaddrs);
     priv->usbaddrs = NULL;