tests: Fix possible NULL derefs in virErrorTestMsgs

Add guards to avoid calling strchr when @err_noinfo == NULL or
calling virErrorTestMsgFormatInfoOne when @err_info == NULL as
both would fail with a NULL deref.

Signed-off-by: John Ferlan <jferlan@redhat.com>
ACKed-by: Peter Krempa <pkrempa@redhat.com>

diff --git a/tests/virerrortest.c b/tests/virerrortest.c
index eebf2593436226f7a9d51183be79dce4e7dd5766..b49d1a91354f7e63383944af477986d4199ead38 100644 (file)
--- a/tests/virerrortest.c
+++ b/tests/virerrortest.c
@@ -74,13 +74,13 @@ virErrorTestMsgs(const void *opaque ATTRIBUTE_UNUSED)
             ret = -1;
         }
 
-        if (strchr(err_noinfo, '%')) {
+        if (err_noinfo && strchr(err_noinfo, '%')) {
             VIR_TEST_VERBOSE("\nerror message id %zu contains formatting characters: '%s'\n",
                              i, err_noinfo);
             ret = -1;
         }
 
-        if (virErrorTestMsgFormatInfoOne(err_info) < 0)
+        if (err_info && virErrorTestMsgFormatInfoOne(err_info) < 0)
             ret = -1;
     }