]> xenbits.xensource.com Git - libvirt.git/commitdiff
Fix a memory leak in the qemudBuildCommandLine.
authorChris Lalancette <clalance@redhat.com>
Fri, 30 Jul 2010 13:39:48 +0000 (09:39 -0400)
committerChris Lalancette <clalance@redhat.com>
Fri, 30 Jul 2010 14:01:50 +0000 (10:01 -0400)
ADD_ARG_LIT should only be used for literal arguments,
since it duplicates the memory.  Since virBufferContentAndReset
is already allocating memory, we should only use ADD_ARG.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
src/qemu/qemu_conf.c

index 7c63bdcb30aae6167855b81274e672542931e858..a79e0d7d84978ee5fa4ce09ff9b188bbce8fb404 100644 (file)
@@ -4110,7 +4110,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
                 goto error;
             }
 
-            ADD_ARG_LIT(virBufferContentAndReset(&boot_buf));
+            ADD_ARG(virBufferContentAndReset(&boot_buf));
         }
 
         if (def->os.kernel) {