iommu/sprd: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230321084125.337021-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c
index ae94d74b73f46f369b54a15c053305d4aa1f781b..907569e76d594985700f8661fe993dc2f8c8bdae 100644 (file)
--- a/drivers/iommu/sprd-iommu.c
+++ b/drivers/iommu/sprd-iommu.c
@@ -507,7 +507,7 @@ free_page:
        return ret;
 }
 
-static int sprd_iommu_remove(struct platform_device *pdev)
+static void sprd_iommu_remove(struct platform_device *pdev)
 {
        struct sprd_iommu_device *sdev = platform_get_drvdata(pdev);
 
@@ -519,8 +519,6 @@ static int sprd_iommu_remove(struct platform_device *pdev)
        platform_set_drvdata(pdev, NULL);
        iommu_device_sysfs_remove(&sdev->iommu);
        iommu_device_unregister(&sdev->iommu);
-
-       return 0;
 }
 
 static struct platform_driver sprd_iommu_driver = {
@@ -530,7 +528,7 @@ static struct platform_driver sprd_iommu_driver = {
                .suppress_bind_attrs = true,
        },
        .probe  = sprd_iommu_probe,
-       .remove = sprd_iommu_remove,
+       .remove_new = sprd_iommu_remove,
 };
 module_platform_driver(sprd_iommu_driver);