]> xenbits.xensource.com Git - pvdrivers/win/xenbus.git/commitdiff
ASSERT Cache method parameters
authorOwen Smith <owen.smith@cloud.com>
Tue, 22 Aug 2023 11:30:04 +0000 (12:30 +0100)
committerPaul Durrant <pdurrant@amazon.com>
Tue, 12 Sep 2023 08:30:21 +0000 (10:30 +0200)
ASSERT the Cache public interface methods are passed valid parameters.

Signed-off-by: Owen Smith <owen.smith@cloud.com>
src/xenbus/cache.c

index 00e16f6fb1f2ea760cdc3ac4889be8c0e490894d..6229aeddefc2d0fec7946cb641a94e203fb7234f 100644 (file)
@@ -602,6 +602,8 @@ CacheGet(
 
     UNREFERENCED_PARAMETER(Interface);
 
+    ASSERT(Cache != NULL);
+
     KeRaiseIrql(DISPATCH_LEVEL, &Irql);
     Index = KeGetCurrentProcessorNumberEx(NULL);
 
@@ -678,6 +680,9 @@ CachePut(
 
     UNREFERENCED_PARAMETER(Interface);
 
+    ASSERT(Cache != NULL);
+    ASSERT(Object != NULL);
+
     KeRaiseIrql(DISPATCH_LEVEL, &Irql);
     Index = KeGetCurrentProcessorNumberEx(NULL);
 
@@ -837,6 +842,14 @@ CacheCreate(
     KIRQL                   Irql;
     NTSTATUS                status;
 
+    ASSERT(Name != NULL);
+    ASSERT(Size != 0);
+    ASSERT(Ctor != NULL);
+    ASSERT(Dtor != NULL);
+    ASSERT(AcquireLock != NULL);
+    ASSERT(ReleaseLock != NULL);
+    ASSERT(Cache != NULL);
+
     Trace("====> (%s)\n", Name);
 
     *Cache = __CacheAllocate(sizeof (XENBUS_CACHE));
@@ -968,6 +981,8 @@ CacheDestroy(
     PXENBUS_CACHE_CONTEXT   Context = Interface->Context;
     KIRQL                   Irql;
 
+    ASSERT(Cache != NULL);
+
     Trace("====> (%s)\n", Cache->Name);
 
     KeAcquireSpinLock(&Context->Lock, &Irql);