]> xenbits.xensource.com Git - xen.git/commitdiff
x86: During cpu offline, cpu_disable_scheduler() cannot fail.
authorKeir Fraser <keir.fraser@citrix.com>
Tue, 1 Jun 2010 12:57:44 +0000 (13:57 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Tue, 1 Jun 2010 12:57:44 +0000 (13:57 +0100)
BUG on this scenario.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen/arch/x86/smpboot.c

index d873e85e25e19c7b72a8ca99cd026906e1a8966f..9581d67e43b3bd37b93cfbbab1656f90574e0940 100644 (file)
@@ -858,7 +858,8 @@ void __cpu_disable(void)
     cpu_clear(cpu, cpu_online_map);
     fixup_irqs();
 
-    cpu_disable_scheduler(cpu);
+    if ( cpu_disable_scheduler(cpu) )
+        BUG();
 }
 
 void __cpu_die(unsigned int cpu)