tests: fix incorrect status handling by virsh-self-test

The virsh-self-test script compared the test's return code with 1 and only if
the return code matched this value then the test was marked as failed. Problem
is that SIGSEGV returns 139 (or 11 to be precise, since shell reserves the MSB
for abnormal exit signaling) which passes the check just fine and test then
appears as successful which it most certainly wasn't.
Therefore, flip the logic to compare against 0 instead and every other result
will be treated as a failed test case.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

diff --git a/tests/virsh-self-test b/tests/virsh-self-test
index c51fcf46f50a18cc7bcfd633b4a288cfb923a147..641810f05fbe17abe420b18d01cfc6db9e8c18c8 100755 (executable)
--- a/tests/virsh-self-test
+++ b/tests/virsh-self-test
@@ -28,7 +28,7 @@ $abs_top_builddir/tools/virsh -c $test_url self-test > /dev/null
 status=$?
 test_result 1 "virsh-self-test" $status
 
-if test "$status" = "1" ; then
+if test "$status" != "0" ; then
    fail=1
 fi