]> xenbits.xensource.com Git - libvirt.git/commitdiff
Remove dead code in qemuDomainAssignPCIAddresses
authorErik Skultety <eskultet@redhat.com>
Thu, 15 Jan 2015 13:14:18 +0000 (14:14 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 16 Jan 2015 09:59:13 +0000 (10:59 +0100)
We tested for positive return value from virDomainMaybeAddController,
but it returns 0 or -1 only resulting in a dead code.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 8091fb3d456d9b336c7beaf7553034475e0ed548..91be16c504ff82539d89062ee8522f7998571f88 100644 (file)
@@ -1509,9 +1509,9 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def,
                          i, bus->model)) < 0)
                     goto cleanup;
                 /* If we added a new bridge, we will need one more address */
-                if (rv > 0 && virDomainPCIAddressReserveNextSlot(addrs, &info,
-                                                                 flags) < 0)
-                        goto cleanup;
+                if (rv == 0 &&
+                    virDomainPCIAddressReserveNextSlot(addrs, &info, flags) < 0)
+                    goto cleanup;
             }
             nbuses = addrs->nbuses;
             virDomainPCIAddressSetFree(addrs);