]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: Fix memory leak in openvzReadFSConf
authorJohn Ferlan <jferlan@redhat.com>
Tue, 16 Jun 2020 12:07:08 +0000 (08:07 -0400)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 16 Jun 2020 13:01:06 +0000 (15:01 +0200)
Since 1f5deed9, @veid_str has been leaked in the error path.

Found by Coverity.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/openvz/openvz_conf.c

index c06bfa13e3cc350cbf3a3accd82883a68d977a6d..190c57b622aee694ae3de19589325eb8837c300e 100644 (file)
@@ -330,7 +330,7 @@ openvzReadFSConf(virDomainDefPtr def,
 {
     int ret;
     virDomainFSDefPtr fs = NULL;
-    char *veid_str = NULL;
+    g_autofree char *veid_str = NULL;
     char *temp = NULL;
     const char *param;
     unsigned long long barrier, limit;
@@ -365,8 +365,6 @@ openvzReadFSConf(virDomainDefPtr def,
         fs->type = VIR_DOMAIN_FS_TYPE_MOUNT;
         if (!(fs->src->path = virStringReplace(temp, "$VEID", veid_str)))
             goto error;
-
-        VIR_FREE(veid_str);
     }
 
     fs->dst = g_strdup("/");