]> xenbits.xensource.com Git - libvirt.git/commitdiff
apparmor: Add capabilities for PCI passthrough to virtxend profile
authorJim Fehlig <jfehlig@suse.com>
Mon, 18 Dec 2023 23:48:13 +0000 (16:48 -0700)
committerJim Fehlig <jfehlig@suse.com>
Tue, 19 Dec 2023 15:53:32 +0000 (08:53 -0700)
When splitting out the apparmor modular daemon profiles from the
libvirtd profile, the net_admin and sys_admin capabilities were
dropped from the virtxend profile. It was not known at the time
that these capabilities were needed for PCI passthrough. Without
the capabilities, the following messages are emitted from the audit
subsystem

audit: type=1400 audit(1702939277.946:63): apparmor="DENIED" \
operation="capable" class="cap" profile="virtxend" pid=3611 \
comm="rpc-virtxend" capability=21  capname="sys_admin"
audit: type=1400 audit(1702940304.818:63): apparmor="DENIED" \
operation="capable" class="cap" profile="virtxend" pid=3731 \
comm="rpc-virtxend" capability=12  capname="net_admin"

It appears sys_admin is needed to simply read from the PCI dev's
sysfs config file. The net_admin capability is needed when setting
the MAC address of an SR-IOV virtual function.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/security/apparmor/usr.sbin.virtxend.in

index 78a11305f5e310a65eddfb830b03feaae591107b..77fedce352c223f6a960065f95a7ae86072534fa 100644 (file)
@@ -5,8 +5,10 @@ profile virtxend @sbindir@/virtxend flags=(attach_disconnected) {
   #include <abstractions/dbus>
 
   capability kill,
+  capability net_admin,
   capability setgid,
   capability setuid,
+  capability sys_admin,
   capability sys_pacct,
   capability ipc_lock,