]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
migration/multifd: Fix p->iov leak in multifd-uadk.c
authorFabiano Rosas <farosas@suse.de>
Wed, 28 Aug 2024 14:56:48 +0000 (11:56 -0300)
committerFabiano Rosas <farosas@suse.de>
Tue, 3 Sep 2024 19:24:36 +0000 (16:24 -0300)
The send_cleanup() hook should free the p->iov that was allocated at
send_setup(). This was missed because the UADK code is conditional on
the presence of the accelerator, so it's not tested by default.

Fixes: 819dd20636 ("migration/multifd: Add UADK initialization")
Reported-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/multifd-uadk.c

index 89f6a72f0e6225e7cc2b78fe91a952f294834a1a..6e6a290ae9876cd2a380542435586258736c5f02 100644 (file)
@@ -132,6 +132,8 @@ static void multifd_uadk_send_cleanup(MultiFDSendParams *p, Error **errp)
 
     multifd_uadk_uninit_sess(wd);
     p->compress_data = NULL;
+    g_free(p->iov);
+    p->iov = NULL;
 }
 
 static inline void prepare_next_iov(MultiFDSendParams *p, void *base,