]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: qemuBlockGetNamedNodeData: Remove pointless error path
authorPeter Krempa <pkrempa@redhat.com>
Wed, 9 Nov 2022 09:45:27 +0000 (10:45 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 9 Nov 2022 13:08:31 +0000 (14:08 +0100)
We don't need automatic freeing for 'blockNamedNodeData' and we can
directly return it rather than checking it for NULL-ness first.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_block.c

index b82e3311e1539d0ba6eb3d2ae0b6a857d54ce8b4..e98b5d4739117c5da457db7de167ea9030be3926 100644 (file)
@@ -2610,7 +2610,7 @@ qemuBlockGetNamedNodeData(virDomainObj *vm,
                           virDomainAsyncJob asyncJob)
 {
     qemuDomainObjPrivate *priv = vm->privateData;
-    g_autoptr(GHashTable) blockNamedNodeData = NULL;
+    GHashTable *blockNamedNodeData = NULL;
     bool supports_flat = virQEMUCapsGet(priv->qemuCaps,
                                         QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT);
 
@@ -2621,10 +2621,7 @@ qemuBlockGetNamedNodeData(virDomainObj *vm,
 
     qemuDomainObjExitMonitor(vm);
 
-    if (!blockNamedNodeData)
-        return NULL;
-
-    return g_steal_pointer(&blockNamedNodeData);
+    return blockNamedNodeData;
 }