]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Don't try to fetch migration stats on destination
authorJiri Denemark <jdenemar@redhat.com>
Mon, 29 Feb 2016 11:34:08 +0000 (12:34 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 1 Mar 2016 14:59:00 +0000 (15:59 +0100)
Migration statistics are not available on the destination host and
starting a query job during incoming migration is not allowed. Trying to
do that would result in

    Timed out during operation: cannot acquire state change lock (held
    by remoteDispatchDomainMigratePrepare3Params)

error. We should not even try to start the job.

https://bugzilla.redhat.com/show_bug.cgi?id=1278727

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_driver.c

index 763dc0e30694c2a6ff6a04f05436cf8c2325798e..4bd40717877c7ba2ffce51e3ba9687ae56674e1d 100644 (file)
@@ -12992,9 +12992,16 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
     if (!priv->job.current || !priv->job.current->stats.status)
         fetch = false;
 
-    if (fetch &&
-        qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
-        return -1;
+    if (fetch) {
+        if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) {
+            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                           _("migration statistics are available only on "
+                             "the source host"));
+            return -1;
+        }
+        if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
+            return -1;
+    }
 
     if (!completed &&
         !virDomainObjIsActive(vm)) {