libs/vchan: Fix -Wsingle-bit-bitfield-constant-conversion

Gitlab reports:

  init.c:348:18: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
          ctrl->is_server = 1;
                          ^ ~
  1 error generated.
  make[6]: *** [/builds/xen-project/people/andyhhp/xen/tools/libs/vchan/../../../tools/Rules.mk:188: init.o] Error 1

In Xen 4.18, this was fixed with c/s 99ab02f63ea8 ("tools: convert bitfields
to unsigned type") but this is an ABI change which can't be backported.

Swich 1 for -1 to provide a minimally invasive way to fix the build.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
index c8510e6ce98a6ca5c6ea9174c044928527356fab..89ddf9c4641587ef1943337c350607476ab41d36 100644 (file)
--- a/tools/libs/vchan/init.c
+++ b/tools/libs/vchan/init.c
@@ -321,7 +321,7 @@ struct libxenvchan *libxenvchan_server_init(struct xentoollog_logger *logger,
 
        ctrl->ring = NULL;
        ctrl->event = NULL;
-       ctrl->is_server = 1;
+       ctrl->is_server = -1;
        ctrl->server_persist = 0;
 
        ctrl->read.order = min_order(left_min);