]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix crash when defining XML with bogus emulator
authorCole Robinson <crobinso@redhat.com>
Fri, 8 Jan 2016 19:46:48 +0000 (14:46 -0500)
committerCole Robinson <crobinso@redhat.com>
Sat, 9 Jan 2016 01:05:31 +0000 (20:05 -0500)
We weren't checking for failure of qemuCaps lookup

src/qemu/qemu_domain.c

index 00c780d8414ba62c6dbeca13da850185d32ac74d..97534c01467e8f50b3d76554015f15f21c79c138 100644 (file)
@@ -1247,7 +1247,9 @@ qemuDomainDefPostParse(virDomainDefPtr def,
         !(def->emulator = virDomainDefGetDefaultEmulator(def, caps)))
         return ret;
 
-    qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator);
+    if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache,
+                                            def->emulator)))
+        goto cleanup;
 
     if (qemuDomainDefAddDefaultDevices(def, qemuCaps) < 0)
         goto cleanup;