]> xenbits.xensource.com Git - unikraft/libs/musl.git/commitdiff
Forward abort calls to Unikraft's UK_CRASH
authorMarco Schlumpp <marco@unikraft.io>
Tue, 18 Apr 2023 12:54:52 +0000 (14:54 +0200)
committerUnikraft <monkey@unikraft.io>
Thu, 4 May 2023 14:30:06 +0000 (14:30 +0000)
The signals are currently ignored and that causes musl to `exit` the
thread, which doesn't cause any output. Therefore, it's very unclear
what happened. By calling `UK_CRASH` there is a clear indication that
something went wrong.

Signed-off-by: Marco Schlumpp <marco@unikraft.io>
Reviewed-by: Eduard Vintilă <eduard.vintila47@gmail.com>
Reviewed-by: Sergiu Moga <sergiu.moga@protonmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
Tested-by: Unikraft CI <monkey@unikraft.io>
GitHub-Closes: #41

Makefile.uk.musl.exit
abort.c [new file with mode: 0644]

index e6a381f69267ee07cc14a3883744c4523b36940f..93a72b3f817fc982d03825797c2d6cae7d2b7862 100644 (file)
@@ -11,7 +11,7 @@ LIBMUSL_EXIT_HDRS-y += $(LIBMUSL)/include/stdlib.h
 LIBMUSL_EXIT_HDRS-y += $(LIBMUSL)/include/syscall.h
 
 
-LIBMUSL_EXIT_SRCS-y += $(LIBMUSL)/src/exit/abort.c
+LIBMUSL_EXIT_SRCS-y += $(LIBMUSL_BASE)/abort.c
 LIBMUSL_EXIT_SRCS-y += $(LIBMUSL)/src/exit/abort_lock.c
 LIBMUSL_EXIT_SRCS-y += $(LIBMUSL)/src/exit/assert.c
 LIBMUSL_EXIT_SRCS-y += $(LIBMUSL)/src/exit/atexit.c
diff --git a/abort.c b/abort.c
new file mode 100644 (file)
index 0000000..e2e187f
--- /dev/null
+++ b/abort.c
@@ -0,0 +1,8 @@
+#include <stdlib.h>
+
+#include <uk/assert.h>
+
+_Noreturn void abort(void)
+{
+       UK_CRASH("abort called\n");
+}
\ No newline at end of file