Add ring disconnect logging.

Logging to note error cases which would otherwise be silent in release builds.
This aids greatly with customer debugging.

Signed-off-by: Martin Harvey <martin.harvey@citrix.com>
Cosmetic fixes.

Signed-off-by: Paul Durrant <paul@xen.org>

diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c
index c70d9382358d696a750775f1ff5b607e6e56cf5a..10ac6f54db29248703c79e9bf50a4fbfe3c0d00b 100644 (file)
--- a/src/xenvif/receiver.c
+++ b/src/xenvif/receiver.c
@@ -2887,6 +2887,14 @@ __ReceiverRingDisconnect(
     ASSERT3U(Ring->ResponsesProcessed, ==, Ring->RequestsPushed);
     ASSERT3U(Ring->RequestsPushed, ==, Ring->RequestsPosted);
 
+    // The above assertions will have no effect in free builds so
+    // trigger some logging instead.
+    if ((Ring->ResponsesProcessed != Ring->RequestsPushed) ||
+        (Ring->RequestsPushed != Ring->RequestsPosted))
+        XENBUS_DEBUG(Trigger,
+                     &Receiver->DebugInterface,
+                     Ring->DebugCallback);
+
     Ring->ResponsesProcessed = 0;
     Ring->RequestsPushed = 0;
     Ring->RequestsPosted = 0;

diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index de9b4768cee65c162bd15a541628279d118ed7c3..ed89f60978f2cd47b1401392a6b92feea673c69f 100644 (file)
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -4005,6 +4005,10 @@ __TransmitterRingDisable(
     }
     if (Ring->ResponsesProcessed != Ring->RequestsPushed)
     {
+        XENBUS_DEBUG(Trigger,
+                     &Transmitter->DebugInterface,
+                     Ring->DebugCallback);
+
         __TransmitterRingFakeResponses(Ring);
         (VOID) TransmitterRingPoll(Ring);
     }