]> xenbits.xensource.com Git - libvirt.git/commitdiff
Fix unused parameters / functions in virsh on Win32
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 21 Jun 2012 13:46:03 +0000 (14:46 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 25 Jun 2012 09:41:10 +0000 (10:41 +0100)
The vshPrintRaw function is not used on Win32, and neither
is the 'msg' parameter of vshAskReedit. Change the nesting
of #ifdef WIN32 conditionals to address this

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
tools/virsh.c

index 75147efd62127dc510ad69d3ec16662d11bfc8d6..567a5f6a0820337d2fa556cab978b6df44f59ccb 100644 (file)
@@ -649,6 +649,7 @@ vshReconnect(vshControl *ctl)
     ctl->useSnapshotOld = false;
 }
 
+#ifndef WIN32
 static void
 vshPrintRaw(vshControl *ctl, ...)
 {
@@ -678,7 +679,6 @@ vshPrintRaw(vshControl *ctl, ...)
 static int
 vshAskReedit(vshControl *ctl, const char *msg)
 {
-#ifndef WIN32
     int c = -1;
     struct termios ttyattr;
 
@@ -714,12 +714,16 @@ vshAskReedit(vshControl *ctl, const char *msg)
 
     vshPrint(ctl, "\r\n");
     return c;
-#else
+}
+#else /* WIN32 */
+static int
+vshAskReedit(vshControl *ctl, const char *msg ATTRIBUTE_UNUSED)
+{
     vshDebug(ctl, VSH_ERR_WARNING, "%s", _("This function is not "
                                            "supported on WIN32 platform"));
     return 0;
-#endif
 }
+#endif /* WIN32 */
 
 /* ---------------
  * Commands