]> xenbits.xensource.com Git - people/liuw/osstest.git/commitdiff
ms-planner: Improve an error message
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 17 Dec 2015 12:10:34 +0000 (12:10 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 5 Jan 2016 17:46:12 +0000 (17:46 +0000)
I experienced this `die' due to mg-schema-test-database failing to
borrow shared hosts properly, and added this Dumper for debugging.

I have not bothered to improve any of the other quite terse `die's in
ms-planner.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
ms-planner

index 6f4a5115516fac5ad07ae83ae0dda9750ecbf618..abf5fac2d7e93a7d374a4ad3dcc6bcf2e2c0a02e 100755 (executable)
@@ -324,7 +324,9 @@ END
        my ($reso, $shareix) = ($`, $1);
 
        my $share= $currentshare{$reso};
-       die unless !!$share == !!$shareix;
+       die Dumper($reskey, $reso, $shareix,
+                  $plan->{Allocations}{$reskey}, $currentshare{$reso})
+           unless !!$share == !!$shareix;
 
         if ($share && $share->{OnlyPreparing}) {
             delete $plan->{Allocations}{$reskey};