]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices
authorPeter Krempa <pkrempa@redhat.com>
Tue, 11 Jun 2024 14:39:41 +0000 (16:39 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 12 Jun 2024 06:21:12 +0000 (08:21 +0200)
The support will be dropped soon by qemu, and libvirt is not rejecting
such configurations. Add validation of this explicitly requested config.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_validate.c

index 3c04f47a1234e5b8dabc7b11f7e5e2ec58eee306..b82d937a0dfe3a5ffdc832aa86309785fb1f61b2 100644 (file)
@@ -2912,6 +2912,11 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDomainDiskDef *disk,
             break;
 
         case VIR_DOMAIN_DISK_BUS_VIRTIO:
+            if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_SCSI)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                               _("This QEMU doesn't support SCSI emulation with 'virtio-blk' device"));
+                return -1;
+            }
             break;
 
         case VIR_DOMAIN_DISK_BUS_NONE: