]> xenbits.xensource.com Git - people/sstabellini/linux-pvhvm-deprecated.git/commitdiff
Revert "HACK! call flush_cache_all() after updating translation table entries"
authorDavid Vrabel <david.vrabel@citrix.com>
Fri, 17 Feb 2012 12:39:10 +0000 (12:39 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 8 Jun 2012 11:57:55 +0000 (11:57 +0000)
This reverts commit 0cd39ddc20a2bbb8ebc4ed48638f30344fd9a808.

This workaround didn't work for all cases (userspace still segfaulted)
and there is now a better workaround.

arch/arm/include/asm/cacheflush.h
arch/arm/mm/fault.c

index 8a326bb56b60c851c2233684dab81e4b9bd879d6..d5d8d5c72682501a54509e9758f90aa31ff127a8 100644 (file)
@@ -336,11 +336,6 @@ static inline void flush_cache_vmap(unsigned long start, unsigned long end)
                 * have a DSB after cleaning the cache line.
                 */
                dsb();
-       /*
-        * FIXME: translation table updates not working right unless
-        * this flush is here.
-        */
-       flush_cache_all();
 }
 
 static inline void flush_cache_vunmap(unsigned long start, unsigned long end)
index f9f9f86191c82dd253dfb3821fa6a2cb8f93fb62..aa33949fef608cb4c5b7b9a76e0f4020ba0f1db6 100644 (file)
@@ -258,14 +258,6 @@ good_area:
         * sure we exit gracefully rather than endlessly redo the fault.
         */
        fault = handle_mm_fault(mm, vma, addr & PAGE_MASK, (fsr & FSR_WRITE) ? FAULT_FLAG_WRITE : 0);
-
-       /*
-        * FIXME: handle_mm_fault() probably updated some translation
-        * table entries and these are not working right unless this
-        * flush is here.
-        */
-       flush_cache_all();
-
        if (unlikely(fault & VM_FAULT_ERROR))
                return fault;
        if (fault & VM_FAULT_MAJOR)