]> xenbits.xensource.com Git - xen.git/commitdiff
x86/efi: address violations of MISRA C:2012 Rule 7.2
authorSimone Ballarin <simone.ballarin@bugseng.com>
Wed, 13 Sep 2023 07:49:14 +0000 (09:49 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 13 Sep 2023 07:49:14 +0000 (09:49 +0200)
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
headline states:
"A 'u' or 'U' suffix shall be applied to all integer constants
that are represented in an unsigned type".

Addi the 'U' suffix to integers literals with unsigned type.

Signed-off-by: Simone Ballarin <simone.ballarin@bugseng.com>
Signed-off-by: Gianluca Luparini <gianluca.luparini@bugseng.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/efi/efi-boot.h

index 92f4cfe8bd119fa3f78b6767584e3d369e46b24a..eebc54180bf7fd1fa34660d47208836317d2509c 100644 (file)
@@ -740,16 +740,16 @@ static void __init efi_arch_handle_module(const struct file *file,
 
 static void __init efi_arch_cpu(void)
 {
-    uint32_t eax = cpuid_eax(0x80000000);
+    uint32_t eax = cpuid_eax(0x80000000U);
     uint32_t *caps = boot_cpu_data.x86_capability;
 
     boot_tsc_stamp = rdtsc();
 
     caps[FEATURESET_1c] = cpuid_ecx(1);
 
-    if ( (eax >> 16) == 0x8000 && eax > 0x80000000 )
+    if ( (eax >> 16) == 0x8000 && eax > 0x80000000U )
     {
-        caps[FEATURESET_e1d] = cpuid_edx(0x80000001);
+        caps[FEATURESET_e1d] = cpuid_edx(0x80000001U);
 
         /*
          * This check purposefully doesn't use cpu_has_nx because