]> xenbits.xensource.com Git - libvirt.git/commitdiff
syntax-check: Drop 'syntax-check' target
authorAndrea Bolognani <abologna@redhat.com>
Fri, 16 Feb 2024 14:03:19 +0000 (15:03 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 19 Feb 2024 09:29:30 +0000 (10:29 +0100)
Our entry point for syntax-check rules is meson, which calls
to each of them specifically; additionally, we have the 'all'
target that warns users who try to use make directly.

The 'syntax-check' target is not used by anything, and in fact
it couldn't be even if one tried: its availability depends on
the $(_gl-Makefile) variable, which in our case is never
defined.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
build-aux/syntax-check.mk

index 359dcbc5fb85e4987070b75d0b7fd411635b076b..0a10259bd87f31db12b8a5875359cad831b39b60 100644 (file)
@@ -1314,27 +1314,6 @@ sc_unportable_grep_q:
        @prohibit='grep ''-q' halt="unportable 'grep ""-q', use >/dev/null instead" \
          $(_sc_search_regexp)
 
-ifneq ($(_gl-Makefile),)
-syntax-check: sc_spacing-check \
-       sc_prohibit-duplicate-header sc_mock-noinline sc_group-qemu-caps \
-        sc_header-ifdef
-       @if ! cppi --version >/dev/null 2>&1; then \
-               echo "*****************************************************" >&2; \
-               echo "* cppi not installed, some checks have been skipped *" >&2; \
-               echo "*****************************************************" >&2; \
-       fi; \
-       if [ -z "$(FLAKE8)" ]; then \
-               echo "*****************************************************" >&2; \
-               echo "* flake8 not installed, sc_flake8 has been skipped  *" >&2; \
-               echo "*****************************************************" >&2; \
-       fi
-       if [ -z "$(BLACK)" ]; then \
-               echo "*****************************************************" >&2; \
-               echo "* black not installed, sc_black has been skipped    *" >&2; \
-               echo "*****************************************************" >&2; \
-       fi
-endif
-
 # Don't include duplicate header in the source (either *.c or *.h)
 sc_prohibit-duplicate-header:
        $(AM_V_GEN)$(VC_LIST_EXCEPT) | $(GREP) '\.[chx]$$' | $(RUNUTF8) xargs \