]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
target/arm/translate.c: Fix missing 'break' for TT insns
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 6 Feb 2018 10:39:41 +0000 (10:39 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 9 Feb 2018 10:55:39 +0000 (10:55 +0000)
The code where we added the TT instruction was accidentally
missing a 'break', which meant that after generating the code
to execute the TT we would fall through to 'goto illegal_op'
and generate code to take an UNDEF insn.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180206103941.13985-1-peter.maydell@linaro.org

target/arm/translate.c

index a8c13d3758a9e7fdd05f45e24fe7ff0e8f793d1b..1270022289c381d4b521553765d5ef52db1c7d93 100644 (file)
@@ -9925,6 +9925,7 @@ static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
                         tcg_temp_free_i32(addr);
                         tcg_temp_free_i32(op);
                         store_reg(s, rd, ttresp);
+                        break;
                     }
                     goto illegal_op;
                 }