]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: min_guarantee: Parameter 'min_guarantee' not supported
authorErik Skultety <eskultet@redhat.com>
Wed, 13 Aug 2014 08:07:46 +0000 (10:07 +0200)
committerJán Tomko <jtomko@redhat.com>
Fri, 22 Aug 2014 14:33:18 +0000 (16:33 +0200)
The 'min_guarantee' is used by VMware ESX and OpenVZ drivers,
with qemu however, libvirt should report error when starting a domain,
because this element is not used.
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1122455

docs/formatdomain.html.in
src/qemu/qemu_process.c

index 6d0ef8e4c720adb67123964f11ed13d4b1b7b8eb..5f6ad5d0b907846cd2bf31176127bd38de7d26dd 100644 (file)
       <dt><code>min_guarantee</code></dt>
       <dd> The optional <code>min_guarantee</code> element is the guaranteed
         minimum memory allocation for the guest. The units for this value are
-        kibibytes (i.e. blocks of 1024 bytes)</dd>
+        kibibytes (i.e. blocks of 1024 bytes). This element is only supported
+        by VMware ESX and OpenVZ drivers.</dd>
     </dl>
 
 
index baa866a1caa202ce2ac9f2b39f25f4e87a378a33..f68dfbee52aad02e2ac7fcd5568c69709fa4d2f2 100644 (file)
@@ -4020,6 +4020,13 @@ int qemuProcessStart(virConnectPtr conn,
                                     flags & VIR_QEMU_PROCESS_START_COLD) < 0)
         goto cleanup;
 
+    if (vm->def->mem.min_guarantee) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("Parameter 'min_guarantee' "
+                         "not supported by QEMU."));
+        goto cleanup;
+    }
+
     if (VIR_ALLOC(priv->monConfig) < 0)
         goto cleanup;