]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy
authorJiri Denemark <jdenemar@redhat.com>
Fri, 15 Sep 2017 14:32:00 +0000 (16:32 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 22 Sep 2017 12:02:59 +0000 (14:02 +0200)
Because qemuDomainDefCopy needs a string representation of a domain
definition, there's no reason for calling the lower level
qemuDomainDefFormatBuf API.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_domain.c

index ddc76b1c932c40c4950daf4fa9cea9ba6d985709..cb371f1e80831fc260c68cf0518a5dd938a5f474 100644 (file)
@@ -4536,14 +4536,12 @@ qemuDomainDefCopy(virQEMUDriverPtr driver,
                   virDomainDefPtr src,
                   unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
     virDomainDefPtr ret = NULL;
-    char *xml = NULL;
+    char *xml;
 
-    if (qemuDomainDefFormatBuf(driver, src, flags, &buf) < 0)
+    if (!(xml = qemuDomainDefFormatXML(driver, src, flags)))
         return NULL;
 
-    xml = virBufferContentAndReset(&buf);
     ret = qemuDomainDefFromXML(driver, xml);
 
     VIR_FREE(xml);