]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
xen/arm: domain_build: Check return code of domain_vpl011_init
authorMichal Orzel <michal.orzel@amd.com>
Thu, 23 Mar 2023 13:56:35 +0000 (14:56 +0100)
committerJulien Grall <jgrall@amazon.com>
Wed, 29 Mar 2023 21:14:52 +0000 (22:14 +0100)
We are assigning return code of domain_vpl011_init() to a variable
without checking it for an error. Fix it.

Fixes: 3580c8b2dfc3 ("xen/arm: if direct-map domain use native UART address and IRQ number for vPL011")
Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
xen/arch/arm/domain_build.c

index 9707eb7b1bb16cb6f3387a84fc72470c1f7ad07c..3195c5b6d6ac3a12bed11a2d3acce547a8c324cd 100644 (file)
@@ -3826,7 +3826,11 @@ static int __init construct_domU(struct domain *d,
      * shall be done first.
      */
     if ( kinfo.vpl011 )
+    {
         rc = domain_vpl011_init(d, NULL);
+        if ( rc < 0 )
+            return rc;
+    }
 
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )