]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: monitor: clear cpu props properly in CPUInfoClear
authorJán Tomko <jtomko@redhat.com>
Thu, 18 Feb 2021 13:23:22 +0000 (14:23 +0100)
committerJán Tomko <jtomko@redhat.com>
Thu, 18 Feb 2021 16:14:47 +0000 (17:14 +0100)
Stay true to the name of the function and clear the pointer
after freeing it.

This also silences a bogus Coverity report about a double
free in qemuMonitorGetCPUInfo where qemuMonitorCPUInfoClear
is called right after allocating a new qemuMonitorCPUInfo
to fill out the non-zero defaults.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_monitor.c

index 0476d606f553bd2c55b05a3b44afb65c27a2e370..151f69acef1a4922579bfdddfad4442c9b9ae884 100644 (file)
@@ -1661,6 +1661,7 @@ qemuMonitorCPUInfoClear(qemuMonitorCPUInfoPtr cpus,
         VIR_FREE(cpus[i].alias);
         VIR_FREE(cpus[i].type);
         virJSONValueFree(cpus[i].props);
+        cpus[i].props = NULL;
     }
 }