]> xenbits.xensource.com Git - people/aperard/linux-chromebook.git/commitdiff
CHROMIUM: arch/arm: do not turn TODO warning into error
authorSimon Que <sque@chromium.org>
Thu, 31 Jan 2013 02:16:08 +0000 (18:16 -0800)
committerChromeBot <chrome-bot@google.com>
Fri, 1 Feb 2013 01:33:27 +0000 (17:33 -0800)
If the build treats warnings as errors (CONFIG_ERROR_ON_WARNING=y), then
do not invoke the "#warn 'TODO'" since it unnecessarily fails the build.

BUG=chromium-os:5542
TEST=emerge-daisy chromeos-kernel, make sure this doesn't appear.

Change-Id: I64c1b4d6079980bbea1f808ac038bf5cbe54beb0
Signed-off-by: Simon Que <sque@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42371
Reviewed-by: Mandeep Singh Baines <msb@chromium.org>
arch/arm/kernel/return_address.c

index 8085417555dd7c49176cd06d88354dd1b2faca67..981087af1c5e6ddb9bbbd4d906c84a06ecb8b0b5 100644 (file)
@@ -58,7 +58,7 @@ void *return_address(unsigned int level)
 
 #else /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */
 
-#if defined(CONFIG_ARM_UNWIND)
+#if defined(CONFIG_ARM_UNWIND) && !defined(CONFIG_ERROR_ON_WARNING)
 #warning "TODO: return_address should use unwind tables"
 #endif