]> xenbits.xensource.com Git - libvirt.git/commitdiff
xml: report the filename (if any) when parsing files
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 16 Aug 2018 12:08:52 +0000 (13:08 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 28 Aug 2018 11:08:21 +0000 (12:08 +0100)
A generic "failed to parse xml document" message without telling us
which XML file failed is quite unhelpful.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/util/virxml.c

index a03a747e603cee33da3832939f9af3219fefa3a6..d1926f4605962ebb8f127e6664f1af307772bf3d 100644 (file)
@@ -847,7 +847,8 @@ virXMLParseHelper(int domcode,
 
     if (virGetLastErrorCode() == VIR_ERR_OK) {
         virGenericReportError(domcode, VIR_ERR_XML_ERROR,
-                              "%s", _("failed to parse xml document"));
+                              _("failed to parse xml document '%s'"),
+                              filename ? filename : "[inline data]");
     }
     goto cleanup;
 }