]> xenbits.xensource.com Git - people/tklengyel/xen.git/commitdiff
include: don't mention stub headers more than once in a make rule
authorJan Beulich <jbeulich@suse.com>
Fri, 31 Mar 2023 06:34:04 +0000 (08:34 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 31 Mar 2023 06:34:04 +0000 (08:34 +0200)
When !GRANT_TABLE and !PV_SHIM headers-n contains grant_table.h twice,
causing make to complain "target '...' given more than once in the same
rule" for the rule generating the stub headers. We don't need duplicate
entries in headers-n anywhere, so zap them (by using $(sort ...)) right
where the final value of the variable is constructed.

Fixes: 6bec713f871f ("include/compat: produce stubs for headers not otherwise generated")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
master commit: 231ab79704cbb5b9be7700287c3b185225d34f1b
master date: 2023-03-28 14:20:16 +0200

xen/include/Makefile

index cfd7851614d86e2769b4970c59ede55a8c3c30c9..e19f9464fd513f23baf25d4975c72027a4107c64 100644 (file)
@@ -34,7 +34,7 @@ headers-$(CONFIG_TRACEBUFFER) += compat/trace.h
 headers-$(CONFIG_XENOPROF) += compat/xenoprof.h
 headers-$(CONFIG_XSM_FLASK) += compat/xsm/flask_op.h
 
-headers-n := $(filter-out $(headers-y),$(headers-n) $(headers-))
+headers-n := $(sort $(filter-out $(headers-y),$(headers-n) $(headers-)))
 
 cppflags-y                := -include public/xen-compat.h -DXEN_GENERATING_COMPAT_HEADERS
 cppflags-$(CONFIG_X86)    += -m32