tools: do not leak uri in disconnect handler

Commit 035947e introduced a call to virConnectGetURI
without a matching free() in virshCatchDisconnect.

Also fix vshAdmCatchDisconnect where it was copied by
commit 6dd7e42.

https://bugzilla.redhat.com/show_bug.cgi?id=1303891

diff --git a/tools/virsh.c b/tools/virsh.c
index 72446be37e7d067f37dd4fe5666f4fd3637644a8..57b4ff34751e471def7be2d8b8f9f8861f0d3cb8 100644 (file)
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -124,6 +124,7 @@ virshCatchDisconnect(virConnectPtr conn,
             break;
         }
         vshError(ctl, _(str), NULLSTR(uri));
+        VIR_FREE(uri);
 
         if (error) {
             virSetError(error);

diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index 3c818a3a29d0234fe873afc0f82a6ef5afb75ac3..c47053639dd0989b6159bd7cc3a8f2fbf4890d61 100644 (file)
--- a/tools/virt-admin.c
+++ b/tools/virt-admin.c
@@ -92,6 +92,7 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn ATTRIBUTE_UNUSED,
     }
 
     vshError(ctl, _(str), NULLSTR(uri));
+    VIR_FREE(uri);
 
     if (error) {
         virSetError(error);